Dave,

Just to tie up the loose end about the default JSObject constructor: No it cannot be package private. JavaFX WebView extends this class.

-- Kevin


Alan Bateman wrote:


On 05/03/2016 18:54, David DeHaven wrote:
I've updated the webrev, hopefully one last time with feedback from Joe Darcy.
http://cr.openjdk.java.net/~ddehaven/8132743/webrev.2/

- Relocated package Javadoc to above the package declaration in package-info.java
- Reworded the Javadoc on the default JSObject ctor

A point was brought up that the default ctor could probably be package-private, but there's no time to investigate what the impact would be so I will file a follow-up issue to investigate doing that at a later date.

This looks okay. Also I assume ServiceLoader.loadInstalled is what you want as you only want to find implementations in the run-time image.

-Alan

Reply via email to