On 01/27/2016 12:10 PM, Alan Bateman wrote:
On 26/01/2016 17:30, huizhe wang wrote:
Hi Felix,
I would feel sorry for Frank since at the time we wanted all tests to
be hosted in the JAXP repo. I understand the intention to consolidate
repos as Alan suggested. However, if the JAXP repo is not hampering
JDK development, I'd prefer an independent JAXP repo as is since it
made JAXP dev much easier. That said, I have no objection to moving
JAXP tests to JDK/test, that'll at least consolidate all of the tests
and you may then take advantage of the JDK/test utilities for current
and future test development.
Alan, what would you think?
We're probably going a bit off-topic here but I don't see why we
persist with the jaxp repository. I think we should have moved the
code to the jdk repository a long time ago. In the short term then it
might be annoying to not have the revision history (hg log)
There might be a way to import jaxp repository into a subdirectory of
jdk repository with all the history:
http://stackoverflow.com/questions/3214717/how-can-i-import-a-mercurial-repo-including-history-into-another-mercurial-rep
...but I don't know if you'd want to do that. I haven't tried it, but I
think this would look in jdk repo as though all changes in jaxp code
were done at a particular point in history when you did the merge. And
you'd end up with two unrelated histories for jaxp code - the one from
jaxp repository and the other from jdk repository. The one in jdk repo
would have different hashes. Old references from Jira would of course
point to jaxp repo and would not be trivially convertible to
corresponding changesets in jdk repo, but you would get an uninterrupted
history of changes, which is sometimes useful.
Regards, Peter
but we've been through this kinda of transition already. Also in the
short term then it might require you or others to do some adjustments
to your IDE setup but that shouldn't be a big deal, esp. with the
source code layout that we put in via the JEP 201 work.
In any case, this all started with my comment about the tests being
split between the jdk and jaxp repo. What would it take to get the new
tests to be located with the existing jaxp tests?
-Alan.
