Amy,
thanks. I'm not sure which practices are suggested. By searching the existing tests, I found lots of test with 2+ @modules, so I chose to add another @modules. Personally, both ways look clear and transparent for me.

Thanks,
Felix
On 2016/4/11 12:49, Amy Lu wrote:
On 4/11/16 11:47 AM, Felix Yang wrote:
Hi there,
    please review the following bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8153928
Webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.00/

You might want to do some cleanup to avoid using two @modules tags?

BTW. I'm not openjdk reviewer, please wait for reviewer's feedback.

Thanks,
Amy


After changes in JDK-8153737 <https://bugs.openjdk.java.net/browse/JDK-8153737>, it introduced new dependency of java.base/jdk.internal.misc in test/lib/share/classes/jdk/test/lib/Utils.java. This leads to two test compilation failures.
See changeset: http://hg.openjdk.java.net/jdk9/dev/rev/1d992540870f

Thanks,
Felix


Reply via email to