Hi Frank,
The test library components seem to duplicate those already in the
JDK/test/lib/testlibrary
There needs to be a good reason to duplicate the test library.
Roger
On 4/14/2016 3:43 AM, Frank Yuan wrote:
-----Original Message-----
From: huizhe wang [mailto:huizhe.w...@oracle.com]
Subject: Re: RFR: 8078820: Test deploying a XML parser as a module
On 4/13/2016 5:55 AM, Alan Bateman wrote:
On 11/04/2016 02:39, Frank Yuan wrote:
Hi Alan and Joe
Would you like to have a look at this review
http://cr.openjdk.java.net/~fyuan/8078820/webrev.01/ ?
I skimmed through the tests and they are testing the right scenarios.
I assume you'll work with Joe to get this into jdk9/dev/jaxp.
Frank,
Is it because of the use of jdk.testlibrary, e.g.
jdk.testlibrary.ProcessTools that you had to put the tests in the jdk repo? Is
it possible to make a copy of the testlibrary or
the
particular functions needed so that we can get this into jdk9/dev/jaxp?
Hi Joe and Alan
I moved the test to jdk9/dev/jaxp with copying the necessary files from
jdk/test/lib/testlibrary to
jaxp/test/javax/xml/jaxp/libs/jdk/testlibrary, and I have to create a separate
directory jaxp/test/javax/xml/jaxp/module for these
new tests because the tests under the existent directories use TestNG.dirs
property, that causes all java files will be compiled
once jtreg runs the test, but the module tests need to control the compilation
by itself.
Please check the new webrev:
http://cr.openjdk.java.net/~fyuan/8078820/webrev.02/ , Thanks!
Frank
-Joe
-Alan
