On 1 May 2016, at 14:50, Andrej Golovnin <andrej.golov...@gmail.com> wrote: > > Hi Alan, > > If you would like to improve the performance a little bit more, > you can make additional changes (see the patch) to JmodTask > and maybe Claes can rerun his tests to see if it helps.
These look good too, even as general clean ups, but it would be good to get some numbers on them. > The patch makes following changes: > > - reads module info in a little bit more efficient way. > - avoids duplicate searching for module info > when hashing of modules is required. > - uses String#lastIndexOf(int) in toPackageName(ZipEntry) > instead of String#lastIndexOf(String). > - avoids checking for every directory entry in a JarFile if it ends > with “module-info.class”. -Chris.
