> On Jun 18, 2016, at 7:45 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 15/06/2016 19:49, Mandy Chung wrote: > >> With further discussion with Chris Bensen and others, we agree that the >> packager would require the presence of the packaged module of jdk.packager >> to be present matching the runtime version of the image being created. The >> packager will determine the root modules and invoke jlink to create the >> resulting image for a non-modular application. To get the root modules for >> a release, one solution is to generate that list at build time. >> >> ModuleFinder currently finds modules for runtime. packager will need to >> detect if the packaged module of jdk.packager is found and matching the >> version of the resulting image being created. This patches provides an API >> to get a ModuleFinder configured for link phase and JDK-8147894 will refresh >> the jlink API to support that. >> > This looks okay. It would nicer if it didn't have otherMods in the API but I > can see how this package it easier for packager. Maybe that can be looked at > again once the jlink API is updated.
I’ll push as is and it should be looked at together when the jlink API is updated. thanks Mandy
