On 02/08/2016 00:21, charbel yazbeck wrote:

hi,


most of the open sources jars have classes with unnamed package, like nar-maven-plugin.

Any idea how can i solve this? Do i have to implement my own version of ModuleFinder?

Some examples: D:\.m2\jdom\jdom\1.0\jdom-1.0.jar, D:\.m2\net\java\dev\javacc\javacc\5.0\javacc-5.0.jar, D:\.m2\hsqldb\hsqldb\1.8.0.7\hsqldb-1.8.0.7.jar


thank you


HelpMojo seems to be something to do with Maven Plugin Plugin. It doesn't seem to be present in nar-maven-plugin 3.3.0 or 3.5.0

$ java --module-path nar-maven-plugin-3.5.0.jar --list-modules nar.maven.plugin
nar.maven.plugin@3.5.0 (file:///d/nar-maven-plugin-3.5.0.jar)
  requires mandated java.base
  exports com.github.maven_nar
  exports com.github.maven_nar.cpptasks
  exports com.github.maven_nar.cpptasks.apple
  exports com.github.maven_nar.cpptasks.arm
  :

We have tried out hundreds of libraries as automatic modules (to test the derivation comes up with sensible module names etc.) and haven't seen too many issues. I did come across javacc, not the others you mention.

The summary is that if you have libraries with types in the unnamed package then they will need to remain on the class path. This means that nobody will be able to use `requires` to name them as a dependence in their module declaration.

-Alan.


Reply via email to