> On Oct 27, 2016, at 3:01 AM, Alan Bateman <[email protected]> wrote:
>
> One thing to check is getHashedModuleNames where it assumes the boot Layer
> exists, I assume this has the potential to NPE if we have any cases where a
> stack trace is printed during early startup.
>
Good catch. It should only call HashedModules.contains(m) after the module
system is initialzed. I added this:
if (VM.isModuleSystemInited() && !HashedModules.contains(m)) {
> Having classOrLoaderModuleClassName change from a class to a string a bit
> unusual but the reasons are clear.
>
> Minor formatting issue in BuiltinClassLoader ctor (would look better without
> the line break).
Fixed.
I also rewrote the examples in the javadoc of StackTraceElement::toString to
make the format clear.
Updated webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.01
Mandy
