> On 15 Dec 2016, at 10:53, Mandy Chung <mandy.ch...@oracle.com> wrote: > > This updates the GenGraphs build tool to generate a dot file for > `java.se` and `java.se.ee` modules including API dependences only > that can be used to display Java SE module graph. > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8171323/webrev.00/ >
Looks ok. You can marginally improve genDotFile: List<ModuleDescriptor> mds = cf.modules().stream() .map(ResolvedModule::reference) .map(ModuleReference::descriptor) .collect(toList()); … printGraph(out, name, gengraph(cf), mds.stream().collect(toMap(ModuleDescriptor::name, Function.identity())); … printGraph(out, name, graph, mds.stream() .filter(md -> !md.name().startsWith("jdk.”) && graph.nodes().contains(md.name())) .collect(toMap(ModuleDescriptor::name, Function.identity())) Paul.