On 01/03/2017 04:56 PM, Lois Foltan wrote:
Hi Claes,
I have some concerns about this change in that it will break the
precedence that currently the only internal form of names that the VM
deals with are binary names as they appear in class files, where the
periods (.) have been replaced by forward slashes (/). I think I would
like to discuss this with the runtime team before you proceed.
Hi Lois,
I have anticipated some controversy on this one. :-)
As far as the actual changes go, if we do proceed with this, there are
places in modules.cpp that have been missed. After line #535, #665,
#749 (the replace should be moved before the verify of the package
name occurs), #820.
Well spotted. I've updated all places:
Hotspot: http://cr.openjdk.java.net/~redestad/8171855/hotspot.02
JDK: http://cr.openjdk.java.net/~redestad/8171855/jdk.01
get_module_by_package_name is only used by the whitebox API and it seems
the test using this was already using internal form.
JVM_GetModuleByPackageName appears to be unused. Could this be cleaned up?
Thanks!
/Claes
Thanks,
Lois
Thanks!
/Claes
