> On Mar 23, 2017, at 7:58 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 22/03/2017 19:11, Mandy Chung wrote: > >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174826/webrev.00/ >> >> This is a proposal to resolve the open issue listed in JEP 282 >> about jlink and service binding. > The output for --suggest-providers looks good. > > For --verbose then the "Providers: " list looks okay when used in conjunction > with --bind-services. I would be tempted to leave it out when --bind-services > is not specified because there is no service binding. >
When linking with explicit providers via —-add-modules, would you think it may be useful to see the list of providers? > A few random comments: > > - JImageTask is now using toUpperCase() which is locale specific and should > be changed. > Fixed. > - Jlink.moduleFinder() unconditionally uses the runtime version. Not a bug > introduced by your changes but this method really needs to locate java.base > and use its version when creating the module path. We should probably create > an issue for that and fix it another time. > I created https://bugs.openjdk.java.net/browse/JDK-8177471 to track this. > - JlinkTask.uses then the stream() isn't needed as Set defines forEach. Good catch. Fixed. Revised webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174826/webrev.01/ Mandy
