Re: RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

[Mandy Chung]

> On Mar 23, 2017, at 1:07 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote:
> 
> Mandy/Daniel,
> 
> yes, jdk.management.agent does require java.management, but not transitively. 
> Shura and I have discussed that and agreed that in such cases a test should 
> declare dependency explicitly, otherwise it can start to fail when some of 
> transitive requires (which are not a part of the contract) are changed.
> 
> I used jdeps with the post-proceccing which makes reduction similar to 
> list-reduced-deps. I have run 'jdeps --list-reduced-deps' on classes from 
> sun/management/jmxremote/bootstrap/CustomLauncherTest.java test run, and it 
> showed the same:
>>   java.management
>>   jdk.attach
>>   jdk.management.agent/jdk.internal.agent
>>   unnamed module: 
>> /tmp/run/jdk/sun/management/jmxremote/bootstrap/JTwork-sun-management-jmxremote-bootstrap-CustomLauncherTest-java_0/classes
> 

It’s good you are using `jdeps --list-reduced-deps`.  It includes 
java.management because the test references the exported APIs from 
java.management.

I agree that @modules should list java.management even though the test 
selection would work properly without it.

Mandy