> On Apr 18, 2017, at 7:35 AM, Alan Bateman <[email protected]> wrote:
>
> For the usage message then --suggest-providers might be simpler as "Suggest
> service providers that implement the given service type from the module
> path". The mention of `--add-modules` could confuse readers so I'd leave it
> out.
>
> In passing, --bind-services currently prints "Do full service binding" and
> maybe we should change that to something "Automaticall link in service
> provider modules and their dependences" or something that is clearer than the
> current text.
>
How about this:
diff --git
a/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties
b/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties
--- a/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties
+++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties
@@ -57,12 +57,12 @@
\ if specified
main.opt.bind-services=\
-\ --bind-services Do full service binding
+\ --bind-services Link in service provider modules
and\n\
+\ their dependences
main.opt.suggest-providers=\
-\ --suggest-providers [<name>,...] Suggest providers of services used
by\n\
-\ the modules that would be linked,
or\n\
-\ of the given service types
+\ --suggest-providers [<name>,...] Suggest providers that implement
the\n\
+\ given service types from the module
path
main.command.files=\
\ @<filename> Read options from file
@@ -138,7 +138,7 @@
warn.signing=WARNING: signed modular JAR {0} is currently not supported
warn.invalid.arg=invalid classname or pathname not exist: {0}
warn.split.package=package {0} defined in {1} {2}
-warn.unused.services=Services specified in --suggest-providers not used: {0}
+warn.provider.notfound=No provider found for service specified to
--suggest-providers: {0}
no.suggested.providers=--bind-services option is specified. No additional
providers suggested.
suggested.providers.header=Suggested providers
providers.header=Providers
> Minor nit in JlinkTask.java L381 where the throw is indented too much, might
> be a tab.
Will fix before I push.
Mandy
