> On May 2, 2017, at 4:28 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > I think this would clutter the class description and it might be better if we > added a note to the getPackages method. >
That’s an alternative. >> src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java >> >> 147 // special mode to boot with only java.base, ignores other >> options >> 148 if (System.getProperty("jdk.module.minimumBoot") != null) { >> 149 return createMinimalBootLayer(); >> 150 } > Is there an issue here? > Not an issue. My mistake forgetting to go back to take this out after went through the webrevs. > >> >> src/java.base/share/classes/jdk/internal/module/ModulePatcher.java >> 123 try (JarFile jf = new JarFile(file.toString())) { >> - what is the bug being fixed by this line? > This is part of the issue that Remi brought up last week related to > overriding the default file system provider. I've replaced > test/java/nio/file/spi/SetDefaultProvider.java with a more comprehensive test > to test overriding with exploded and modular JAR that are patched / > not-patched. > Thanks. I now remember it. Mandy