Hi Claes, thanks for your quick review. I configured my IDE to go to wildcard at 10 imports from the same package. But if there's a common style guide for OpenJDK, I can certainly reconfigure this.
Best regards Christoph > -----Original Message----- > From: Claes Redestad <claes.redes...@oracle.com> > Sent: Sonntag, 19. April 2020 18:32 > To: Langer, Christoph <christoph.lan...@sap.com>; jigsaw- > d...@openjdk.java.net > Cc: core-libs-...@openjdk.java.net > Subject: Re: RFR (T): 8243117: Cleanups in Java code of module jdk.jlink > > Looks good to me, Christoph, > > JmodTask.java: Not sure what the consensus is about wildcard imports, > but I'm fine with it here. > > /Claes > > On 2020-04-19 17:32, Langer, Christoph wrote: > > Hi, > > > > please help review this cleanup patch for the Java code in module jdk.jlink. > It's mostly automatic IDE cleanups of unused imports plus a few removals for > unused private methods, fields and annotations. I've also added some > @Override annotations where such were missing. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8243117 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8243117.0/ > > > > Thanks > > Christoph > >
