[ 
https://issues.apache.org/jira/browse/ARROW-9426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157221#comment-17157221
 ] 

FredGan commented on ARROW-9426:
--------------------------------

Sorry that it's not redundant. But two same "entry" key in the same level of 
YAML maybe showed errror in some IDE, such as "Goland".

I think maybe it's better that merge the two entries to one, such like 

```

entry: bash -c "pip install cmake-format && python run-cmake-format.py --check; 
echo"

```

I run the "pre-commit run -a" , but I find many CMake files are re-formatted. 

How do you think about this? [~wesm]

 

> [CI] Maybe redundant 'entry' key in .pre-commit-config.yaml
> -----------------------------------------------------------
>
>                 Key: ARROW-9426
>                 URL: https://issues.apache.org/jira/browse/ARROW-9426
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: CI
>            Reporter: Chen
>            Priority: Minor
>
> Hi, occasionally I find a mior issue in the '.pre-commit-config.yaml' file 
> that.
> ```yaml
> - id: cmake-format
>   name: CMake Format
>   language: python
>   entry: bash -c "pip install cmake-format && python run-cmake-format.py 
> --check"
>   entry: echo
>   files: ^(.*/CMakeLists.txt|.*.cmake)$
> ```
> Maybe the item `entry: echo` is redundant. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to