[ https://issues.apache.org/jira/browse/ARROW-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157248#comment-17157248 ]
Uwe Korn commented on ARROW-9171: --------------------------------- I would be able to squeeze this in but I have the feeling that this might break some downstream users again and thus lead to delays in the release process, so delaying it shortly after the release. > [C++] Comments in FindArrow.cmake misleading > -------------------------------------------- > > Key: ARROW-9171 > URL: https://issues.apache.org/jira/browse/ARROW-9171 > Project: Apache Arrow > Issue Type: Bug > Components: C++, Packaging > Reporter: Antoine Pitrou > Priority: Major > Fix For: 2.0.0 > > > When you try to find out how to use Arrow from a third-party project, you may > read the comments in FindArrow.cmake: > {code} > # This module defines > # ARROW_FOUND, whether Arrow has been found > # ARROW_FULL_SO_VERSION, full shared object version of found Arrow "100.0.0" > # ARROW_IMPORT_LIB, path to libarrow's import library (Windows only) > # ARROW_INCLUDE_DIR, directory containing headers > # ARROW_LIBS, deprecated. Use ARROW_LIB_DIR instead > # ARROW_LIB_DIR, directory containing Arrow libraries > # ARROW_SHARED_IMP_LIB, deprecated. Use ARROW_IMPORT_LIB instead > # ARROW_SHARED_LIB, path to libarrow's shared library > # ARROW_SO_VERSION, shared object version of found Arrow such as "100" > # ARROW_STATIC_LIB, path to libarrow.a > # ARROW_VERSION, version of found Arrow > # ARROW_VERSION_MAJOR, major version of found Arrow > # ARROW_VERSION_MINOR, minor version of found Arrow > # ARROW_VERSION_PATCH, patch version of found Arrow > {code} > ... only to find out that {{find_package(Arrow)}} doesn't set most of those > variables: > * it sets {{Arrow_FOUND}}, not {{ARROW_FOUND}} > * {{ARROW_INCLUDE_DIR}}, {{ARROW_SHARED_LIB}}, {{ARROW_STATIC_LIB}} are not > set > * to link with Arrow C++, you have to link with either {{arrow_shared}} or > {{arrow_static}} > Also, I wonder if Arrow should follow the more recent convention of naming > its targets e.g. {{Arrow::Arrow}} or {{arrow::arrow}} (or specifically > {{arrow::shared}}). -- This message was sent by Atlassian Jira (v8.3.4#803005)