[
https://issues.apache.org/jira/browse/ARROW-11870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296228#comment-17296228
]
Jorge Leitão commented on ARROW-11870:
--------------------------------------
:) I would not mind writing one for this.
I never gave a different answer than "enter, enter, enter, enter" when all
looked good. If something would not look good for the bot, it should just fail
and reply something on the PR.
The most likely scenario is a merge conflict that the contributor needs to fix.
In this case, the bot pings the user directly on the PR, instead of us having
to do it, which is great!
less common cases are:
* components missing. IMO we should just derive them from the PR's title when
they do not exist. They must exist on the PR or the bot complaints like we
already do.
* assignee missing. This is manual as there is no SSO experience on Jira that
we can use to derive a user <> github user relation
* version. It happens during RCs and the like. Those cases fall into the
"manual" merge (or we can also extend the bot to understand "@bot please merge
vX.Y.Z" if we want to go crazy)
> [Dev] Automatically run merge script in venv
> --------------------------------------------
>
> Key: ARROW-11870
> URL: https://issues.apache.org/jira/browse/ARROW-11870
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Developer Tools
> Reporter: Antoine Pitrou
> Assignee: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Running the merge script needs some additional boilerplate for people who
> don't already use a Conda environment or similar.
> We could provide a wrapper script {{dev/merge_arrow_pr.sh}} that:
> 1) checks if a virtual env {{dev/.venv}} exists
> 2) if not, creates it and installs the required dependencies
> 3) runs the Python merge script in the virtual env
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
