[ https://issues.apache.org/jira/browse/ARROW-11994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303003#comment-17303003 ]
Ian Cook edited comment on ARROW-11994 at 3/17/21, 12:56 AM: ------------------------------------------------------------- Yep, ARROW-11735 didn't change anything in {{cpp/}}. IIRC it was and is possible to build libarrow with {{ARROW_DATASET=ON}} and {{ARROW_PARQUET=OFF}} but the build might fail if both are not actually installed and building that way might cause runtime errors. was (Author: icook): Yep, ARROW-11735 didn't change anything in {{cpp/}}. IIRC it was and is possible to build libarrow with {{ARROW_DATASET=ON}} and {{ARROW_PARQUET=OFF}} but the build might fail if both are not actually installed and that building that way might cause runtime errors. > [R] Build fails if dataset enabled but parquet is not > ----------------------------------------------------- > > Key: ARROW-11994 > URL: https://issues.apache.org/jira/browse/ARROW-11994 > Project: Apache Arrow > Issue Type: Bug > Components: R > Reporter: Neal Richardson > Priority: Minor > > Following ARROW-11735; discovered while working on ARROW-10734. The > arrow::dataset::ParquetFileFormat and related classes require both dataset > and parquet. The {{#if defined}} logic in r/src/dataset.cpp is right and both > are required, but in the wrapping that is generated for arrowExports.cpp, we > only use the annotation on the functions, {{[[dataset::export]]}} to wrap. So > the ParquetFileFormat methods in arrowExports.cpp are if defined > ARROW_R_WITH_DATASET and fail if parquet is not available. > Not a priority to fix (for Solaris I can turn off ARROW_DATASET and avoid > this), just wanted to note it in case we need to revisit this wrapping logic > later anyway. cc [~icook] -- This message was sent by Atlassian Jira (v8.3.4#803005)