[ 
https://issues.apache.org/jira/browse/ARROW-13267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375968#comment-17375968
 ] 

Antoine Pitrou commented on ARROW-13267:
----------------------------------------

I'm not sure adding implicit queueing is a good idea. Allowing to reliably 
distinguish reentrant and non-reentrant generators sounds useful however.

> [C++] Distinguish between async-reentrant generators and unsafe generators
> --------------------------------------------------------------------------
>
>                 Key: ARROW-13267
>                 URL: https://issues.apache.org/jira/browse/ARROW-13267
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Weston Pace
>            Priority: Major
>
> Right now there are a lot of comments in the MakeXyzGenerator functions 
> explaining if a generator can be called async reentrantly and if it will call 
> input generators async reentrantly.  Rather than rely on comments and the 
> user doing the right thing we could create types for the two generators.  The 
> unsafe generator could even serve as a base type that queues incoming 
> requests.  This way all generators would technically be async reentrant and 
> it would hopefully remove some of the confusion.
>  
> This does mean converting async generators from aliases of std::function to 
> actual types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to