[
https://issues.apache.org/jira/browse/ARROW-13853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421552#comment-17421552
]
Eduardo Ponce edited comment on ARROW-13853 at 9/28/21, 5:26 PM:
-----------------------------------------------------------------
If (for now) we are going to not accept locale option but still want to match
*stringr* API, I can think of any of these approaches:
* *str_to_lower(x, locale = "en")* -> only accept "en" locale and error if
other
* *str_to_lower(x, locale = NULL)* -> only accept NULL locale (ie., not
supported) and error if another value is given
* *str_to_lower(x, locale)* -> use *missing()* function to R to detect locale
arg, if it is provided then error out
* *str_to_lower(x)* -> non-matching API
cc [~npr] Any suggestions?
was (Author: edponce):
If (for now) we are going to not accept locale option but still want to match
*stringr* API, I can think of any of these approaches:
* *str_to_lower(x, locale = "en")* -> only accept "en" locale and error if
other
* *str_to_lower(x, locale = NULL)* -> only accept NULL locale (ie., not
supported) and error if another value is given
* *str_to_lower(x, locale)* -> use *missing()* function to R to detect locale
arg, if it is provided then error out
* *str_to_lower(x)* -> non-matching API
cc [~npr] Any suggestions?
> [R] String to_title, to_lower, to_upper kernels
> -----------------------------------------------
>
> Key: ARROW-13853
> URL: https://issues.apache.org/jira/browse/ARROW-13853
> Project: Apache Arrow
> Issue Type: New Feature
> Components: R
> Reporter: Neal Richardson
> Assignee: Eduardo Ponce
> Priority: Major
> Labels: kernel, pull-request-available
> Fix For: 6.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> ARROW-12714 added the *str_to_title* kernel and a basic mapping, but we
> should add a test. Also the stringr function takes a "locale" argument which
> is not handled here; we should either pass it to Arrow C++ if it supports it
> (which I doubt) or error if a value is provided in R.
> This also applies to *str_to_lower* and *str_to_upper* kernels.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
