[ 
https://issues.apache.org/jira/browse/ARROW-13853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421631#comment-17421631
 ] 

Neal Richardson commented on ARROW-13853:
-----------------------------------------

I made a suggestion on the PR

> [R] String to_title, to_lower, to_upper kernels
> -----------------------------------------------
>
>                 Key: ARROW-13853
>                 URL: https://issues.apache.org/jira/browse/ARROW-13853
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: R
>            Reporter: Neal Richardson
>            Assignee: Eduardo Ponce
>            Priority: Major
>              Labels: kernel, pull-request-available
>             Fix For: 6.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> ARROW-12714 added the *str_to_title* kernel and a basic mapping, but we 
> should add a test. Also the stringr function takes a "locale" argument which 
> is not handled here; we should either pass it to Arrow C++ if it supports it 
> (which I doubt) or error if a value is provided in R.
> This also applies to *str_to_lower* and *str_to_upper* kernels.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to