[ 
https://issues.apache.org/jira/browse/ARROW-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427069#comment-17427069
 ] 

Antoine Pitrou commented on ARROW-14274:
----------------------------------------

I am not aware that base64 is performance critical currently. That said, I'm ok 
with improving the code, or even using a totally different implementation if 
desired.

> [C++] Upgrade vendored base64 code
> ----------------------------------
>
>                 Key: ARROW-14274
>                 URL: https://issues.apache.org/jira/browse/ARROW-14274
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Yibo Cai
>            Assignee: Yibo Cai
>            Priority: Major
>
> The vendored base64 code looks suboptimal. [1]
> We should at least upgrade to latest upstream code which improved a lot. [2]
> Maybe adopt more optimized implementation if base64 performance matters for 
> arrow. [3]
> [1] 
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/vendored/base64.cpp#L49
> [2] https://github.com/ReneNyffenegger/cpp-base64/blob/master/base64.cpp#L129
> [3] https://github.com/aklomp/base64



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to