[ 
https://issues.apache.org/jira/browse/ARROW-14291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427442#comment-17427442
 ] 

Kouhei Sutou edited comment on ARROW-14291 at 10/12/21, 4:34 AM:
-----------------------------------------------------------------

We already have lint fix by CI feature: 
https://github.com/apache/arrow/blob/master/.github/workflows/comment_bot.yml#L52

Our C++ lint targets are only {{cpp/src/}}: 
https://github.com/apache/arrow/blob/master/cpp/CMakeLists.txt#L243

They don't include {{cpp/examples}}.


was (Author: kou):
We already have this feature: 
https://github.com/apache/arrow/blob/master/.github/workflows/comment_bot.yml#L52

Our C++ lint targets are only {{cpp/src/}}: 
https://github.com/apache/arrow/blob/master/cpp/CMakeLists.txt#L243

They don't include {{cpp/examples}}.

> Use CI for linting
> ------------------
>
>                 Key: ARROW-14291
>                 URL: https://issues.apache.org/jira/browse/ARROW-14291
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Benson Muite
>            Assignee: Benson Muite
>            Priority: Minor
>
> Currently the development process requires the developer to lint their code 
> before committing it. This can be inefficient for changes made in the browser 
> and when one has a different compiler setup than that used for linting. As 
> described in 
> [https://dev.to/flipp-engineering/linting-only-changed-files-with-github-actions-4ddp]
>  development efficiency can be improved if altered code is automatically 
> linted by a CI action.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to