[
https://issues.apache.org/jira/browse/ARROW-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454129#comment-17454129
]
Supun Kamburugamuva commented on ARROW-13672:
---------------------------------------------
The BaseBinaryBuilder has a constructor that accepts the type parameter but is
not used. I think what the issue says is we should store this type and return
it in the type() method.
Someone using the BaseBinaryBuilder can override these two methods and achieve
the same. So I'm thinking is there a value in implementing this? The
FinishInternal is implemented correctly as it uses the type() method to get the
type in a derived class.
> [C++] BinaryBuilder doesn't preserve passed in DataType
> -------------------------------------------------------
>
> Key: ARROW-13672
> URL: https://issues.apache.org/jira/browse/ARROW-13672
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 5.0.0
> Reporter: Micah Kornfield
> Assignee: Supun Kamburugamuva
> Priority: Minor
> Labels: beginner, good-first-issue
>
> There is a
> [constructor|https://github.com/apache/arrow/blob/1430c93f68960e10a50d27f465eb174e76ac06b2/cpp/src/arrow/array/builder_binary.h#L56]
> that takes a datatype for binary builder but it is discarded. When
> constructing an Array the type is always the value returned from type()
> [binary|https://github.com/apache/arrow/blob/1430c93f68960e10a50d27f465eb174e76ac06b2/cpp/src/arrow/array/builder_binary.h#L390]
> If a consumer of the API wants to have an extension array this prevents them
> from passing the extension type though.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
