[
https://issues.apache.org/jira/browse/ARROW-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476451#comment-17476451
]
Weston Pace commented on ARROW-12358:
-------------------------------------
This
(https://github.com/apache/arrow/compare/master...westonpace:feature/ARROW-12358--only-call-delete-contents-if-needed)
would be one possible fix but not easily regressible (I suppose I could mock
out a filesystem to make sure we don't call delete contents on an empty
directory but that seems like a lot of complexity)
This
(https://github.com/apache/arrow/compare/master...westonpace:feature/ARROW-12358--pass-delete-contents-if-dir-not-there)
would be another possible fix and it's easily regressible but does lead to
different filesystems acting differently (although we already have some of this)
[~jorisvandenbossche][~lidavidm] opinions?
> [C++][Python][R][Dataset] Control overwriting vs appending when writing to
> existing dataset
> -------------------------------------------------------------------------------------------
>
> Key: ARROW-12358
> URL: https://issues.apache.org/jira/browse/ARROW-12358
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Joris Van den Bossche
> Priority: Major
> Labels: dataset
> Fix For: 8.0.0
>
>
> Currently, the dataset writing (eg with {{pyarrow.dataset.write_dataset}})
> uses a fixed filename template ({{"part\{i\}.ext"}}). This means that when
> you are writing to an existing dataset, you de facto overwrite previous data
> when using this default template.
> There is some discussion in ARROW-10695 about how the user can avoid this by
> ensuring the file names are unique (the user can specify the
> {{basename_template}} to be something unique). There is also ARROW-7706 about
> silently doubling data (so _not_ overwriting existing data) with the legacy
> {{parquet.write_to_dataset}} implementation.
> It could be good to have a "mode" when writing datasets that controls the
> different possible behaviours. And erroring when there is pre-existing data
> in the target directory is maybe the safest default, because both appending
> vs overwriting silently can be surprising behaviour depending on your
> expectations.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
