[
https://issues.apache.org/jira/browse/ARROW-16158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522370#comment-17522370
]
Antoine Pitrou commented on ARROW-16158:
----------------------------------------
I agree with renaming to ARROW_SUBSTRAIT as it's a more explicit and
informative name for the component anyway.
> [C++] rename ARROW_ENGINE to ARROW_SUBSTRAIT
> --------------------------------------------
>
> Key: ARROW-16158
> URL: https://issues.apache.org/jira/browse/ARROW-16158
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Jonathan Keane
> Priority: Blocker
> Fix For: 8.0.0
>
>
> When we introduced substrait we reused the cmake + feature {{ARROW_ENGINE}}
> to mean compute+a few other things as well as the substrait consumer
> functionality. In general, right now, we don't yet need (or want) to build
> substrait in our packages (e.g. the R package) since many places don't yet
> take advantage of it. But the naming of the cmake or feature is now
> confusing: it effectively is only substrait if you separately enable compute,
> etc. but it makes it sound like the query engine we have been building since
> 6.0.0 is disabled.
> We should rename {{ARROW_ENGINE}} to {{ARROW_SUBSTRAIT}} now and then we can
> add an {{ARROW_ENGINE}} later if we need to encompass a larger set of engine
> functionality (e.g. compute+spillover+scheduler+memory limits) if that's
> needed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
