[ 
https://issues.apache.org/jira/browse/ARROW-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529519#comment-17529519
 ] 

Weston Pace edited comment on ARROW-16392 at 4/28/22 4:30 PM:
--------------------------------------------------------------

Right now if we see {{file:///}} we drop the first 7 characters.  When we get a 
URI with a drive letter:

{noformat}
file:///C:/
{noformat}

We need to drop the first 8 characters.  The easiest thing to do would be to 
check if the first segment ends in a colon and assume it's a drive letter.


was (Author: westonpace):
Right now if we see {{file:///}} we drop the first 7 characters.  When we get a 
URI with a drive letter:

{noformat}
file:///C:/}}
{noformat}

We need to drop the first 8 characters.  The easiest thing to do would be to 
check if the first segment ends in a colon and assume it's a drive letter.

> [C++] Substrait consumer cannot handle file URIs that contain a Windows drive 
> letter
> ------------------------------------------------------------------------------------
>
>                 Key: ARROW-16392
>                 URL: https://issues.apache.org/jira/browse/ARROW-16392
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Vibhatha Lakmal Abeykoon
>            Assignee: Vibhatha Lakmal Abeykoon
>            Priority: Major
>
> Observed the following when looking into a functional test for file reading 
> in a Substrait Plan. 
> Referring to the existing logic here: 
> https://github.com/apache/arrow/blob/e0061bbb8cd269f4e8b880d1a4ba181312cbc07f/cpp/src/arrow/engine/substrait/relation_internal.cc#L114
> This needs to be changed to acustom support for Windows.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to