[
https://issues.apache.org/jira/browse/ARROW-16609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542118#comment-17542118
]
Weston Pace commented on ARROW-16609:
-------------------------------------
I think [~apitrou]'s output would be valuable here. I believe he is out until
next week however.
My two cents, fwiw, is:
{{MultiplyWithOverflow/AddWithOverflow/SubtractWithOverflow}} - These are
shallow wrappers around a vendored version of
https://github.com/nemequ/portable-snippets/tree/master/safe-math . I do not
think it makes sense to expose these. Instead I think it would make sense for
pyarrow to vendor this library on its own (or to find some spot to stick the
vendored library in the repo so that both libs can use it).
{{ScalarMemoTable}} - This is a more complex utility that would not be very
easy to replicate. I think we should consider refactoring
{{arrow::internal::ScalarMemoTable}} into a public header file (and probably
renaming to {{arrow::ScalarMemoTable}}).
> [C++] xxhash not installed into dist/lib/include when building C++
> ------------------------------------------------------------------
>
> Key: ARROW-16609
> URL: https://issues.apache.org/jira/browse/ARROW-16609
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Alenka Frim
> Priority: Blocker
> Fix For: 9.0.0
>
>
> My C++ build setup doesn’t install {{dist/include/arrow/vendored/xxhash/}}
> but only {{dist/include/arrow/vendored/xxhash.h}}. The last time the module
> was installed was in november 2021.
> As {{arrow/python/arrow_to_pandas.cc}} includes {{arrow/util/hashing.h}} ->
> {{arrow/vendored/xxhash.h}} -> {{arrow/vendored/xxhash/xxhash.h}} this
> module is needed to try to build Python C++ API separately from C++
> (ARROW-16340).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
