[ 
https://issues.apache.org/jira/browse/ARROW-16543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552616#comment-17552616
 ] 

Teodor Kostov commented on ARROW-16543:
---------------------------------------

Here is a full test:

{code:javascript}
const dataType = new arrow.Struct([
  new arrow.Field('time', new arrow.TimestampSecond()),
  new arrow.Field('value', new arrow.Float64()),
])
const builder = arrow.makeBuilder({ type: dataType, nullValues: [null, 
undefined] })

const date = new Date()
const timestampSeconds = Math.floor(date.getTime() / 1000)
const timestamp = timestampSeconds * 1000
builder.append({ time: date, value: 1.2 })
builder.append({ time: date, value: 3.3 })
builder.finish()
const vector = builder.toVector()

const schema = new arrow.Schema(dataType.children)
const recordBatch = new arrow.RecordBatch(schema, vector.data[0])
const table = new arrow.Table(recordBatch)

console.log(timestamp)
console.log(timestampSeconds)
console.log(table.get(0).time)

console.log(table.get(0).time === timestamp) // should be false
console.log(table.get(0).time === timestampSeconds) // should be true
{code}
 

> [JS] Timestamp types are all the same
> -------------------------------------
>
>                 Key: ARROW-16543
>                 URL: https://issues.apache.org/jira/browse/ARROW-16543
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: JavaScript
>            Reporter: Teodor Kostov
>            Priority: Major
>
> Current timestamp types are all the same. They have the same representation. 
> And also the same precision.
> For example, {{TimestampSecond}} and {{TimestampMillisecond}} return the 
> values as {{1652118180000}}. Instead, I would expect the {{TimestampSecond}} 
> to drop the 3 zeros when returning a value, e.g. {{1652118180}}. Also, the 
> representation underneath is still an {{int32}} array. Even though for 
> {{TimestampSecond}} every second value is {{0}}, the array still has double 
> the amount of integers.
> I also got an error when trying to read a {{Date}} as {{TimestampNanosecond}} 
> - {{TypeError: can't convert 1652118180000 to BigInt}}.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to