[ 
https://issues.apache.org/jira/browse/ARROW-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598175#comment-17598175
 ] 

Alenka Frim commented on ARROW-17571:
-------------------------------------

Joris ;)

> [Benchmarks] Default build for PyArrow seems to be debug
> --------------------------------------------------------
>
>                 Key: ARROW-17571
>                 URL: https://issues.apache.org/jira/browse/ARROW-17571
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Benchmarking, Python
>            Reporter: Alenka Frim
>            Assignee: Alenka Frim
>            Priority: Major
>             Fix For: 10.0.0
>
>
> After a benchmark regression was identified in the [Python refactoring 
> PR|https://github.com/apache/arrow/pull/13311] we identified the cause is in 
> the build script for benchmarks. In the file _dev/conbench_envs/hooks.sh_ the 
> script used to build PyArrow is _ci/scripts/python_build.sh_ where the 
> default for PyArrow build type is set to *debug* (assuming _CMAKE_BUILD_TYPE_ 
> isn't defined)
> See:
> [https://github.com/apache/arrow/blob/74dae618ed8d6b492bf3b88e3b9b7dfd4c21e8d8/dev/conbench_envs/hooks.sh#L60-L62]
> [https://github.com/apache/arrow/blob/93b63e8f3b4880927ccbd5522c967df79e926cda/ci/scripts/python_build.sh#L55]
>  
> I think we need to change the build type to release in 
> _dev/conbench_envs/hooks.sh_ (_build_arrow_python()_) or maybe better to set 
> the variable _CMAKE_BUILD_TYPE_ to release in 
> _dev/conbench_envs/benchmarks.env_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to