[ 
https://issues.apache.org/jira/browse/ARROW-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ARROW-17659:
-----------------------------------
    Labels: pull-request-available  (was: )

> Populate JDBC schema name metadata when config.shouldIncludeMetadata provided
> -----------------------------------------------------------------------------
>
>                 Key: ARROW-17659
>                 URL: https://issues.apache.org/jira/browse/ARROW-17659
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 9.0.0
>            Reporter: Igor Suhorukov
>            Assignee: Igor Suhorukov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Current implementation include 
> [catalog,table,column,type|https://github.com/apache/arrow/blob/master/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowUtils.java#L248]
>  metadata, but schema metadata field is missing. In terms of PostgreSQL 
> catalog - is database, schema - namespace inside database, so catalog name is 
> insufficient for table addressing without schema.
>  
> Proposed changes is:
> {code:java}
> metadata.put(Constants.SQL_CATALOG_NAME_KEY, rsmd.getCatalogName(i));
> metadata.put(Constants.SQL_SCHEMA_KEY, rsmd.getSchemaName(i));
> metadata.put(Constants.SQL_TABLE_NAME_KEY, rsmd.getTableName(i));
> metadata.put(Constants.SQL_COLUMN_NAME_KEY, columnName);
> metadata.put(Constants.SQL_TYPE_KEY, rsmd.getColumnTypeName(i));{code}
> But this fix required to change assertions for metadata checks in many tests 
> in arrow-jdbc module



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to