[
https://issues.apache.org/jira/browse/ARROW-17904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615403#comment-17615403
]
Kouhei Sutou commented on ARROW-17904:
--------------------------------------
I'm OK with the vendoring approach if we can find a fast simple CRC32
implementation.
> https://github.com/robn/cyrus-imapd/blob/master/lib/crc32.c
If we use Cyrus's implementation, we should use
https://github.com/cyrusimap/cyrus-imapd/blob/master/lib/crc32.c not forked one.
If we can't find a fast simple CRC32 implementation, I prefer to use (not
vendor) the zlib's implementation for maintainability.
> [C++] Parquet support read page with crc32 checking
> ---------------------------------------------------
>
> Key: ARROW-17904
> URL: https://issues.apache.org/jira/browse/ARROW-17904
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Parquet
> Affects Versions: 9.0.0
> Reporter: Xuwei Fu
> Assignee: Xuwei Fu
> Priority: Major
> Labels: pull-request-available
> Fix For: 11.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, C++'s Parquet support write page with checksum, but `ReadPage`
> doesn't have check any checksum. And I would like to fix it
> I'd like to split this patch to different parts:
> # Implement the crc in DataPageV1, which requires a write crc config,
> counting crc in read mode, crc verification, migrate testing from parquet mr
> # Implement crc in DataPageV2 and Dict
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
