[
https://issues.apache.org/jira/browse/ARROW-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17659413#comment-17659413
]
Rok Mihevc commented on ARROW-2386:
-----------------------------------
This issue has been migrated to [issue
#18420|https://github.com/apache/arrow/issues/18420] on GitHub. Please see the
[migration documentation|https://github.com/apache/arrow/issues/14542] for
further details.
> [Plasma] Change PlasmaClient::Create API
> ----------------------------------------
>
> Key: ARROW-2386
> URL: https://issues.apache.org/jira/browse/ARROW-2386
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++ - Plasma
> Reporter: Philipp Moritz
> Priority: Major
>
> Now that the Get API is refactored in
> [https://github.com/apache/arrow/pull/1807,] we should do the same for the
> Create API.
> Proposal:
> Have a MutablePlasmaBuffer class, which is returned by Create
> {code:java}
> Status Create(int64_t data_size, int64_t metadata_size,
> std::shared_ptr<MutablePlasmaBuffer>* buffer)
> {code}
> This allocates the data in shared memory, but does not associate it with the
> object id yet. This way we get get rid of the Abort() call.
> Move the Seal() method into the MutablePlasmaBuffer and let it return the
> object ID.
>
> This is very similar to what [~pitrou] suggested here:
> https://github.com/apache/arrow/pull/1807
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
