[
https://issues.apache.org/jira/browse/ARROW-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17661686#comment-17661686
]
Rok Mihevc commented on ARROW-4664:
-----------------------------------
This issue has been migrated to [issue
#21195|https://github.com/apache/arrow/issues/21195] on GitHub. Please see the
[migration documentation|https://github.com/apache/arrow/issues/14542] for
further details.
> [C++] DCHECK macro conditions are evaluated in release builds
> -------------------------------------------------------------
>
> Key: ARROW-4664
> URL: https://issues.apache.org/jira/browse/ARROW-4664
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Ben Kietzman
> Assignee: Wes McKinney
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 0.13.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {{DCHECK(potentially_expensive())}} will evaluate the argument even in
> release mode, and is used in several places with the assumption that it will
> do so (which means removing the guarantee of evaluation causes numerous
> failures). By contrast, most debug assertion macros elide their arguments
> entirely ({{<cassert>.assert}}, {{<glog/logging.h>}}) in release mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
