[ 
https://issues.apache.org/jira/browse/ARROW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17661288#comment-17661288
 ] 

Rok Mihevc commented on ARROW-4264:
-----------------------------------

This issue has been migrated to [issue 
#20841|https://github.com/apache/arrow/issues/20841] on GitHub. Please see the 
[migration documentation|https://github.com/apache/arrow/issues/14542] for 
further details.

> [C++] Document why DCHECKs are used in kernels
> ----------------------------------------------
>
>                 Key: ARROW-4264
>                 URL: https://issues.apache.org/jira/browse/ARROW-4264
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Micah Kornfield
>            Assignee: Micah Kornfield
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 0.13.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> DCHECKs seem to be used where Status::Invalid might be considered more 
> appropriate (so programs don't crash).  See conversation on 
> [https://github.com/apache/arrow/pull/3287/files]
> based on conversation on this Jira and on the CL it seems DCHECKS are in fact 
> desired but we should document appropriate use for them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to