[ https://issues.apache.org/jira/browse/KAFKA-5470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054179#comment-16054179 ]
ASF GitHub Bot commented on KAFKA-5470: --------------------------------------- GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3371 KAFKA-5470: Replace -XX:+DisableExplicitGC with -XX:+ExplicitGCInvokesConcurrent in kafka-run-class You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-5470-explicit-gc-invokes-concurrent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3371 ---- commit da81116ca8d5c9c75ea447c0febe11f97a67957a Author: Ismael Juma <ism...@juma.me.uk> Date: 2017-06-19T15:17:46Z KAFKA-5470: Replace -XX:+DisableExplicitGC with -XX:+ExplicitGCInvokesConcurrent in kafka-run-class ---- > Replace -XX:+DisableExplicitGC with -XX:+ExplicitGCInvokesConcurrent in > kafka-run-class > --------------------------------------------------------------------------------------- > > Key: KAFKA-5470 > URL: https://issues.apache.org/jira/browse/KAFKA-5470 > Project: Kafka > Issue Type: Improvement > Reporter: Ismael Juma > Assignee: Ismael Juma > Priority: Critical > Fix For: 0.11.0.1 > > > This is important because Bits.reserveMemory calls System.gc() hoping to free > native memory in order to avoid throwing an OutOfMemoryException. This call > is currently a no-op due to -XX:+DisableExplicitGC. > It's worth mentioning that -XX:MaxDirectMemorySize can be used to increase > the amount of native memory available for allocation of direct byte buffers. > Hongyuan Li pointed out the issue with the usage of -XX:+DisableExplicitGC > in: > https://issues.apache.org/jira/browse/KAFKA-5444?focusedCommentId=16054129&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16054129 -- This message was sent by Atlassian JIRA (v6.4.14#64029)