[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062837#comment-16062837
]
ASF GitHub Bot commented on KAFKA-4750:
---------------------------------------
GitHub user evis opened a pull request:
https://github.com/apache/kafka/pull/3430
KAFKA-4750: RocksDBStore always deletes null values
@guozhangwang @mjsax
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/evis/kafka rocksdbstore_null_values
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3430
----
commit 47b4b2b2a5fe8af4ca4a60c2cae97dcab4e7eec3
Author: Evgeny Veretennikov <evg.veretenni...@gmail.com>
Date: 2017-06-26T09:21:35Z
KAFKA-4750: RocksDBStore always deletes null values
Deletion occurs even if serde serializes null value
to non-null byte array.
----
> KeyValueIterator returns null values
> ------------------------------------
>
> Key: KAFKA-4750
> URL: https://issues.apache.org/jira/browse/KAFKA-4750
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 0.10.1.1, 0.11.0.0, 0.10.2.1
> Reporter: Michal Borowiecki
> Assignee: Evgeny Veretennikov
> Labels: newbie
> Attachments: DeleteTest.java
>
>
> The API for ReadOnlyKeyValueStore.range method promises the returned iterator
> will not return null values. However, after upgrading from 0.10.0.0 to
> 0.10.1.1 we found null values are returned causing NPEs on our side.
> I found this happens after removing entries from the store and I found
> resemblance to SAMZA-94 defect. The problem seems to be as it was there, when
> deleting entries and having a serializer that does not return null when null
> is passed in, the state store doesn't actually delete that key/value pair but
> the iterator will return null value for that key.
> When I modified our serilizer to return null when null is passed in, the
> problem went away. However, I believe this should be fixed in kafka streams,
> perhaps with a similar approach as SAMZA-94.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
