[
https://issues.apache.org/jira/browse/KAFKA-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102290#comment-16102290
]
ASF GitHub Bot commented on KAFKA-5658:
---------------------------------------
GitHub user cmccabe opened a pull request:
https://github.com/apache/kafka/pull/3584
KAFKA-5658. Fix AdminClient request timeout handling bug resulting in
continual BrokerNotAvailableExceptions
The AdminClient does not properly clear calls from the callsInFlight
structure. Later, in an effort to clear the lingering call objects, it closes
the connection they are associated with. This disrupts new incoming calls,
which then get BrokerNotAvailableException.
This patch fixes this bug by properly removing completed calls from the
callsInFlight structure. It also adds the Call#aborted flag, which ensures
that we only abort a connection once-- even if there is a similar bug in the
future which causes old Call objects to linger. This patch also fixes a case
where AdminClient#describeConfigs was making an extra RPC that had no useful
effect.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmccabe/kafka KAFKA-5658
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3584.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3584
----
commit 7eedf51d2b29565460f04f78435f2bdf5a9cd661
Author: Colin P. Mccabe <cmcc...@confluent.io>
Date: 2017-07-17T17:04:58Z
KAFKA-5602: ducker-ak: support --custom-ducktape
Support a --custom-ducktape flag which allows developers to install
their own versions of ducktape into Docker images. This is helpful for
ducktape development.
commit 811983f02cb1ff887bbe75ffc22ef51f98a99a36
Author: Colin P. Mccabe <cmcc...@confluent.io>
Date: 2017-07-26T20:57:18Z
KAFKA-5658. Fix AdminClient request timeout handling bug resulting in
continual BrokerNotAvailableExceptions
----
> Fix AdminClient request timeout handling bug resulting in continual
> BrokerNotAvailableExceptions
> ------------------------------------------------------------------------------------------------
>
> Key: KAFKA-5658
> URL: https://issues.apache.org/jira/browse/KAFKA-5658
> Project: Kafka
> Issue Type: Bug
> Reporter: dan norwood
> Assignee: Colin P. McCabe
> Priority: Critical
> Labels: reliability
> Fix For: 0.11.0.1
>
>
> The AdminClient does not properly clear calls from the callsInFlight
> structure. Later, in an effort to clear the lingering call objects, it
> closes the connection they are associated with. This disrupts new incoming
> calls, which then get {{java.util.concurrent.ExecutionException:
> org.apache.kafka.common.errors.BrokerNotAvailableException}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
