[ 
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107672#comment-16107672
 ] 

Guozhang Wang commented on KAFKA-1944:
--------------------------------------

Also agree with [~hachikuji] that we should consider deprecating the config 
(but not renaming it instantaneously) and introduce a new config, along with 
the class name changes. In addition, the values taken should be considered; I'm 
thinking that:

0. Default value of the new config should be the same as the deprecated config, 
i.e. {{true}}
1. If both deprecated and new config values are specified, log a WARN entry and 
choose the new config value.
2. If only one of them is specified, choose its value.
3. If none of them are specified, then the default value, which should be the 
same, will be used.

> Rename LogCleaner and related classes to LogCompactor
> -----------------------------------------------------
>
>                 Key: KAFKA-1944
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1944
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Gwen Shapira
>            Assignee: Aravind Selvan
>              Labels: newbie
>
> Following a mailing list discussion:
> "the name LogCleaner is seriously misleading. Its more of a log compactor. 
> Deleting old logs happens elsewhere from what I've seen."
> Note that this may require renaming related classes, objects, configs and 
> metrics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to