[
https://issues.apache.org/jira/browse/KAFKA-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113861#comment-16113861
]
ASF GitHub Bot commented on KAFKA-5700:
---------------------------------------
GitHub user huxihx opened a pull request:
https://github.com/apache/kafka/pull/3620
KAFKA-5700: Producer should not drop header information when splitting
batches
Producer should not drop header information when splitting batches. This
PR also corrects a minor typo in Sender.java, where `spitting and retrying`
should be `splitting and retrying`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huxihx/kafka KAFKA-5700
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3620.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3620
----
commit 105ba9051f53d1872c3fd13efb4fad991183e651
Author: huxihx <huxi...@hotmail.com>
Date: 2017-08-04T03:21:26Z
KAFKA-5700: Producer should not drop header information when splitting big
batches.
This PR also corrects a minor typo in Sender.java, where `spitting and
retrying` should be `splitting and retrying`.
----
> producer missed header information when splitting batches
> ---------------------------------------------------------
>
> Key: KAFKA-5700
> URL: https://issues.apache.org/jira/browse/KAFKA-5700
> Project: Kafka
> Issue Type: Bug
> Components: producer
> Affects Versions: 0.11.0.0
> Reporter: huxihx
> Assignee: huxihx
>
> In `ProducerBatch.tryAppendForSplit`, invoking
> `this.recordsBuilder.append(timestamp, key, value);` missed the header
> information in the ProducerRecord. Should invoke this like :
> `this.recordsBuilder.append(timestamp, key, value, headers);`
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
