[ https://issues.apache.org/jira/browse/KAFKA-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117994#comment-16117994 ]
Chanchal Singh edited comment on KAFKA-5676 at 8/8/17 12:31 PM: ---------------------------------------------------------------- Hi Wang , testMetrics() in StreamTaskTest class , ProcessorNodeTest class and NamedCacheTest class. ProcessorNodeTest uses MockStreamsMetrics object from MockProcessorContext. Please let me know if my understanding is correct. I have committed the code after removing metrics object parameter from MockStreamsMetrics constructor and referencing the StreamsMetricsImpl in classes where testMetrics() is used . was (Author: chanchal.kafka): Hi Wang , testMetrics() in StreamTaskTest class , ProcessorNodeTest class and NamedCacheTest class. ProcessorNodeTest uses MockStreamsMetrics object from MockProcessorContext. Please let me know if my understanding is correct. I have committed the code after removing metrics object parameter from MockStreamsMetrics constructor and referencing the StreamsMetricsImpl in classes where testMetrics() is used but still MockStreamsMetrics is extending StreamsMetricsImpl. > MockStreamsMetrics should be in o.a.k.test > ------------------------------------------ > > Key: KAFKA-5676 > URL: https://issues.apache.org/jira/browse/KAFKA-5676 > Project: Kafka > Issue Type: Bug > Components: streams > Reporter: Guozhang Wang > Assignee: Chanchal Singh > Labels: newbie > > {{MockStreamsMetrics}}'s package should be `o.a.k.test` not > `o.a.k.streams.processor.internals`. > In addition, it should not require a {{Metrics}} parameter in its constructor > as it is only needed for its extended base class; the right way of mocking > should be implementing {{StreamsMetrics}} with mock behavior than extended a > real implementaion of {{StreamsMetricsImpl}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)