[ 
https://issues.apache.org/jira/browse/KAFKA-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118418#comment-16118418
 ] 

ASF GitHub Bot commented on KAFKA-2526:
---------------------------------------

GitHub user aishraj opened a pull request:

    https://github.com/apache/kafka/pull/3643

    MINOR: Error when incompatible console producer configs.

    Spinned off from 
[KAFKA-2526](https://issues.apache.org/jira/browse/KAFKA-2526), to throw an 
exception if the console producer is passed a key serializer or a value 
serializer.
    To quote a comment on the JIRA:
    > The longer term solution with a KIP is obviously a lot more involved, but 
you should feel free to work on it; it would be a useful improvement. Since 
there would be two separate steps, you'd probably want to either file a 
separate JIRA for the better error messages and leave this one to the KIP or 
just file that fix as a MINOR PR.
    
    Hence opening as a MINOR PR

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aishraj/kafka trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3643.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3643
    
----
commit d6f22459e59ff631849b6bec193ea0f9e33eb3fa
Author: Aish Raj Dahal <a...@aishraj.com>
Date:   2017-08-08T14:41:09Z

    MINOR: Error when incompatible console producer configs.
    
    Spinned off from KAFKA-2526, throw an exception if the console producer is 
passed a key serializer or a value serializer.

----


> Console Producer / Consumer's serde config is not working
> ---------------------------------------------------------
>
>                 Key: KAFKA-2526
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2526
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>            Assignee: Mayuresh Gharat
>              Labels: newbie
>
> Although in the console producer one can specify the key value serializer, 
> they are actually not used since 1) it always serialize the input string as 
> String.getBytes (hence always pre-assume the string serializer) and 2) it is 
> actually only passed into the old producer. The same issues exist in console 
> consumer.
> In addition the configs in the console producer is messy: we have 1) some 
> config values exposed as cmd parameters, and 2) some config values in 
> --producer-property and 3) some in --property.
> It will be great to clean the configs up in both console producer and 
> consumer, and put them into a single --property parameter which could 
> possibly take a file to reading in property values as well, and only leave 
> --new-producer as the other command line parameter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to