[
https://issues.apache.org/jira/browse/KAFKA-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141432#comment-16141432
]
ASF GitHub Bot commented on KAFKA-5771:
---------------------------------------
GitHub user radzish opened a pull request:
https://github.com/apache/kafka/pull/3737
KAFKA-5771: org.apache.kafka.streams.state.internals.Segments#segments
method returns incorrect results when segments were added out of order
Suggested fix for the bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radzish/kafka KAFKA-5771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3737.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3737
----
commit 32f8da5d0b39c449303a8dcd34476ed2b68197e6
Author: radzish <radz...@gmail.com>
Date: 2017-08-25T09:39:18Z
KAFKA-5771: org.apache.kafka.streams.state.internals.Segments#segments
method returns incorrect results when segments were added out of order
----
> org.apache.kafka.streams.state.internals.Segments#segments method returns
> incorrect results when segments were added out of order
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-5771
> URL: https://issues.apache.org/jira/browse/KAFKA-5771
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 0.11.0.0
> Reporter: Alexander Radzishevsky
>
> following unit test in org.apache.kafka.streams.state.internals.SegmentsTest
> will fail
> {code:title=org.apache.kafka.streams.state.internals.SegmentsTest.java|borderStyle=solid}
> @Test
> public void shouldGetSegmentsWithinTimeRangeOutOfOrder() throws Exception
> {
> segments.getOrCreateSegment(4, context);
> segments.getOrCreateSegment(2, context);
> segments.getOrCreateSegment(0, context);
> segments.getOrCreateSegment(1, context);
> segments.getOrCreateSegment(3, context);
> final List<Segment> segments = this.segments.segments(0, 2 * 60 *
> 1000);
> assertEquals(3, segments.size());
> assertEquals(0, segments.get(0).id);
> assertEquals(1, segments.get(1).id);
> assertEquals(2, segments.get(2).id);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
