[ https://issues.apache.org/jira/browse/KAFKA-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145467#comment-16145467 ]
ASF GitHub Bot commented on KAFKA-5804: --------------------------------------- GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3754 KAFKA-5804: retain duplicates in ChangeLoggingWindowBytesStore `ChangeLoggingWindowBytesStore` needs to have the same `retainDuplicates` functionality as `RocksDBWindowStore` else data could be lost upon failover/restoration. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dguy/kafka hotfix-changelog-window-store Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3754.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3754 ---- commit d63358a67a98d2fbd53ea47f9b7d54c5dd65b937 Author: Damian Guy <damian....@gmail.com> Date: 2017-08-29T15:18:31Z retain duplicates in ChangeLoggingWindowBytesStore ---- > ChangeLoggingWindowBytesStore needs to retain duplicates when writing to the > log > -------------------------------------------------------------------------------- > > Key: KAFKA-5804 > URL: https://issues.apache.org/jira/browse/KAFKA-5804 > Project: Kafka > Issue Type: Bug > Components: streams > Reporter: Damian Guy > Assignee: Damian Guy > Fix For: 1.0.0 > > > The {{ChangeLoggingWindowBytesStore}} needs to have the same duplicate > retaining logic as {{RocksDBWindowStore}} otherwise data loss may occur when > performing windowed joins. -- This message was sent by Atlassian JIRA (v6.4.14#64029)