[
https://issues.apache.org/jira/browse/KAFKA-5765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169140#comment-16169140
]
ASF GitHub Bot commented on KAFKA-5765:
---------------------------------------
GitHub user ConcurrencyPractitioner reopened a pull request:
https://github.com/apache/kafka/pull/3880
KAFKA-5765 Move merge() from StreamsBuilder to KStream
I have defined a {{merge()}} method to KStream.
KStreamImpl overrides the {{merge()}} method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ConcurrencyPractitioner/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3880
----
commit 572f5bfa5a0e334c5b75a6e3353aa6f4b5b95f39
Author: Richard Yu <richar...@richards-air.attlocal.net>
Date: 2017-09-16T23:38:53Z
KAFKA-5765 diff --git
a/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
b/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
commit 71ac422ceb86e5c1d368a714b0af743eb2ad62eb
Author: Richard Yu <richar...@richards-air.attlocal.net>
Date: 2017-09-16T23:54:10Z
KAFKA-5765 Move merge() from StreamsBuilder to KStream
----
> Move merge() from StreamsBuilder to KStream
> -------------------------------------------
>
> Key: KAFKA-5765
> URL: https://issues.apache.org/jira/browse/KAFKA-5765
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 0.11.0.0, 1.0.0
> Reporter: Matthias J. Sax
> Assignee: Richard Yu
> Labels: needs-kip, newbie
> Fix For: 1.1.0
>
> Attachments: 5765.v1.patch
>
>
> Merging multiple {{KStream}} is done via {{StreamsBuilder#merge()}} (formally
> {{KStreamBuilder#merge()}}). This is quite unnatural and should be done via
> {{KStream#merge()}}.
> We need a KIP as we add a new method to a public {{KStreams}} API and
> deprecate the old {{merge()}} method.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
