[ https://issues.apache.org/jira/browse/KAFKA-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180822#comment-16180822 ]
ASF GitHub Bot commented on KAFKA-5679: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3668 > Add logging to distinguish between internally and externally initiated > shutdown of Kafka > ---------------------------------------------------------------------------------------- > > Key: KAFKA-5679 > URL: https://issues.apache.org/jira/browse/KAFKA-5679 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.11.0.0 > Reporter: Apurva Mehta > Assignee: Rajini Sivaram > Fix For: 1.0.0 > > > Currently, if there is an internal error that triggers a shutdown of the > Kafka server, the {{Exit}} class is used, which begins the shutdown > procedure. The other way a shutdown is triggered is by {{SIGTERM}} or some > other signal. > We would like to distinguish between shutdown due to internal errors and > external signals. This helps when debugging. Particularly, a natural question > when a broker shuts down unexpectedly is: "did the deployment system send > the signal or is there some un logged fatal error in the broker"? > Today, we rely on callers of {{Exit}} to log the error before making the > call. However, this won't always have 100% coverage. It would be good to add > a log message in {{Exit}} to record that an exit method was invoked > explicitly. > We could also add a signal handler to log when {{SIGTERM}}, {{SIGKILL}} etc. > are received. > This would make operating Kafka a bit easier. -- This message was sent by Atlassian JIRA (v6.4.14#64029)