[
https://issues.apache.org/jira/browse/KAFKA-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201005#comment-16201005
]
ASF GitHub Bot commented on KAFKA-6032:
---------------------------------------
GitHub user gilles-degols opened a pull request:
https://github.com/apache/kafka/pull/4061
KAFKA-6032: Unit Tests should be independent of locale settings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gilles-degols/kafka
KAFKA-6032-Unit-Tests-should-be-independent-of-locale-settings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4061.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4061
----
commit d80207ec7a74cf5cffacdf2cf9cd7d43f60880a5
Author: Gilles Degols <gil...@degols.net>
Date: 2017-10-11T21:30:06Z
Unit Tests should be independent of locale settings
----
> Unit Tests should be independent of locale settings
> ---------------------------------------------------
>
> Key: KAFKA-6032
> URL: https://issues.apache.org/jira/browse/KAFKA-6032
> Project: Kafka
> Issue Type: Bug
> Components: unit tests
> Affects Versions: 0.11.0.0
> Environment: Centos 7, Windows 10
> Locale = "fr_BE.UTF-8"
> Reporter: Gilles Degols
> Assignee: Gilles Degols
> Priority: Minor
> Labels: newbie
>
> If the system has locale settings like "fr_BE.UTF-8", 3 unit tests will fail:
> 1. org.apache.kafka.common.utils.ShellTest > testRunProgramWithErrorReturn
> 2. org.apache.kafka.common.utils.ShellTest >
> testAttemptToRunNonExistentProgram
> 3. org.apache.kafka.common.utils.UtilsTest > testFormatBytes
> They rely on string comparisons which will not work if the system throws an
> error in another language, or if the float format is different ("," instead
> of ".").
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
