[ https://issues.apache.org/jira/browse/KAFKA-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234301#comment-16234301 ]
ASF GitHub Bot commented on KAFKA-5950: --------------------------------------- GitHub user adyach opened a pull request: https://github.com/apache/kafka/pull/4167 KAFKA-5950: retry on response retriable exception The PR will add retries for KafkaAdminClient's retriable error responses. You can merge this pull request into a Git repository by running: $ git pull https://github.com/adyach/kafka KAFKA-5950 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4167.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4167 ---- commit ec46619ad3a3bdcc9f0eb73ba93d25dd9a485f11 Author: Andrey Dyachkov <andrey.dyach...@zalando.de> Date: 2017-11-01T16:08:24Z KAFKA-5950: retry on response retriable exception ---- > AdminClient should retry based on returned error codes > ------------------------------------------------------ > > Key: KAFKA-5950 > URL: https://issues.apache.org/jira/browse/KAFKA-5950 > Project: Kafka > Issue Type: Bug > Reporter: Ismael Juma > Assignee: Andrey Dyachkov > Priority: Major > Labels: needs-kip > Fix For: 1.1.0 > > > The AdminClient only retries if the request fails with a retriable error. If > a response is returned, then a retry is never attempted. This is inconsistent > with other clients that check the error codes in the response and retry for > each retriable error code. > We should consider if it makes sense to adopt this behaviour in the > AdminClient so that users don't have to do it themselves. -- This message was sent by Atlassian JIRA (v6.4.14#64029)