[
https://issues.apache.org/jira/browse/KAFKA-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237148#comment-16237148
]
ASF GitHub Bot commented on KAFKA-6156:
---------------------------------------
GitHub user huxihx opened a pull request:
https://github.com/apache/kafka/pull/4173
KAFKA-6156: Metric tag name should not contain colons.
Windows directory paths often contain colons which are now allowed in
yammer metrics. Should convert to its corresponding Unix style path before
creating metrics.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huxihx/kafka KAFKA-6156
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4173
----
commit 36a1188a3f9c93d21f68b591d4fd16fa90bd8bad
Author: huxihx <huxi...@hotmail.com>
Date: 2017-11-03T06:13:47Z
KAFKA-6156: Metric tag name should not contain colons.
Windows directory paths often contain colons which are now allowed in
yammer metrics. Should convert to its corresponding Unix style path before
creating metrics.
----
> JmxReporter can't handle windows style directory paths
> ------------------------------------------------------
>
> Key: KAFKA-6156
> URL: https://issues.apache.org/jira/browse/KAFKA-6156
> Project: Kafka
> Issue Type: Bug
> Components: metrics
> Affects Versions: 1.0.0
> Environment: JDK 8u152 (64 Bit), Windows 10 (64 Bit)
> Reporter: Kedar Joshi
> Priority: Minor
> Attachments: Kafka.log
>
>
> *com.yammer.metrics.reporting.JmxReporter* complains about special characters
> in windows log directory path. Following warning is printed during startup -
> {noformat}
> [2017-11-01 20:39:24,567] INFO Loading logs. (kafka.log.LogManager)
> [2017-11-01 20:39:24,583] INFO Logs loading complete in 16 ms.
> (kafka.log.LogManager)
> [2017-11-01 20:39:24,630] WARN Error processing
> kafka.log:type=LogManager,name=LogDirectoryOffline,logDirectory=D:\tmp\kafka-logs
> (com.yammer.metrics.reporting.JmxReporter)
> javax.management.MalformedObjectNameException: Invalid character ':' in value
> part of property
> at javax.management.ObjectName.construct(ObjectName.java:618)
> at javax.management.ObjectName.<init>(ObjectName.java:1382)
> at
> com.yammer.metrics.reporting.JmxReporter.onMetricAdded(JmxReporter.java:395)
> at
> com.yammer.metrics.core.MetricsRegistry.notifyMetricAdded(MetricsRegistry.java:516)
> at
> com.yammer.metrics.core.MetricsRegistry.getOrAdd(MetricsRegistry.java:491)
> at
> com.yammer.metrics.core.MetricsRegistry.newGauge(MetricsRegistry.java:79)
> at
> kafka.metrics.KafkaMetricsGroup.newGauge(KafkaMetricsGroup.scala:74)
> at
> kafka.metrics.KafkaMetricsGroup.newGauge$(KafkaMetricsGroup.scala:73)
> at kafka.log.LogManager.newGauge(LogManager.scala:50)
> at kafka.log.LogManager.$anonfun$new$1(LogManager.scala:122)
> at
> scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:59)
> at
> scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:52)
> at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
> at kafka.log.LogManager.<init>(LogManager.scala:116)
> at kafka.log.LogManager$.apply(LogManager.scala:814)
> at kafka.server.KafkaServer.startup(KafkaServer.scala:222)
> at
> kafka.server.KafkaServerStartable.startup(KafkaServerStartable.scala:38)
> at kafka.Kafka$.main(Kafka.scala:92)
> at kafka.Kafka.main(Kafka.scala)
> {noformat}
> Complete log is attached.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
